fix(toolkit-lib): tracing logs on watch action does not close immediately #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
==========================================
- Coverage 79.61% 79.06% -0.56%
==========================================
Files 47 47
Lines 7083 7083
Branches 798 792 -6
==========================================
- Hits 5639 5600 -39
- Misses 1423 1464 +41
+ Partials 21 19 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
otaviomacedo
approved these changes
Jun 3, 2025
aws-cdk-automation
deleted the
mrgrain/fix/cloudWatchLogMonitor-not-closing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
CloudWatchLogEventMonitorwasn't closed immediately when theFileWatcherreturned fromwatch()was disposed. This wasn't super bad, since it would only wait for one additional tick to finish, but also isn't great.This was discovered by jest reporting open handles. Well done jest!
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license